dialects (hw): Fix Formatting #2317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
math-fehr
approved these changes
Mar 7, 2024
|
It’s unclear to me what the correct formatting is for empty functions. In #2251 I had to insert these line breaks (reverted here) because same-line ellipses failed the CI. Are those now expected to be consistently on the same line? |
|
We recently updated the version in the precommit, as it was out of date with the one in the CI. Can you run make precommit-install again? Sorry about the confusion, I should probably have made more of an announcement. There's also a vague idea of making it less broken by finding the value to use dynamically from requirements.txt but I can't make any promises about timelines :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick PR to fix the currently failing CI